Impl config module - #23
Merged
Merged
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #23 +/- ##
==========================================
Coverage ? 78.72%
==========================================
Files ? 197
Lines ? 21468
Branches ? 2056
==========================================
Hits ? 16900
Misses ? 4568
Partials ? 0 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mykola-kobets-epam
approved these changes
Jun 30, 2025
Collaborator
|
|
mykola-kobets-epam
approved these changes
Jun 30, 2025
mykola-kobets-epam
left a comment
mykola-kobets-epam
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed-by: Mykola Kobets <mykola_kobets@epam.com>
mlohvynenko
reviewed
Jun 30, 2025
mlohvynenko
reviewed
Jun 30, 2025
mlohvynenko
reviewed
Jun 30, 2025
mlohvynenko
reviewed
Jun 30, 2025
mlohvynenko
approved these changes
Jun 30, 2025
mlohvynenko
left a comment
mlohvynenko
left a comment
Member
There was a problem hiding this comment.
Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com>
al1img
reviewed
Jul 2, 2025
| @@ -36,6 +36,7 @@ add_subdirectory(logprovider) | |||
| add_subdirectory(migration) | |||
Collaborator
There was a problem hiding this comment.
commit message
common: config:
| #include <filesystem> | ||
|
|
||
| #include <common/utils/exception.hpp> | ||
|
|
| { | ||
| try { | ||
| const auto pollPeriod = object.GetValue<std::string>("pollPeriod", cDefaultMonitoringPollPeriod); | ||
|
|
| * Functions | ||
| **********************************************************************************************************************/ | ||
|
|
||
| /* |
Collaborator
There was a problem hiding this comment.
I expect here only one method:
/*
* Parses config from file.
*
* @param filename config file name.
* @param[out] config config instance.
* @return Error.
*/
Error ParseConfig(const std::string& filename, Config& config);Similar to SM.
Author
There was a problem hiding this comment.
But this is a general function in common, which is used in SM and CM
MykolaSuperman
force-pushed
the
config
branch
2 times, most recently
from
July 3, 2025 06:55
df82478 to
cf5bd0a
Compare
al1img
approved these changes
Jul 4, 2025
al1img
left a comment
al1img
left a comment
Collaborator
There was a problem hiding this comment.
Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
added 3 commits
July 4, 2025 15:17
Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
Signed-off-by: Mykola Solianko <mykola_solianko@epam.com> Reviewed-by: Mykola Kobets <mykola_kobets@epam.com> Reviewed-by: Mykhailo Lohvynenko <mykhailo_lohvynenko@epam.com> Reviewed-by: Oleksandr Grytsov <oleksandr_grytsov@epam.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.